qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1/2] qemu-ga: generate missing stubs for fsfreez


From: Michael Roth
Subject: Re: [Qemu-devel] [PATCH 1/2] qemu-ga: generate missing stubs for fsfreeze
Date: Thu, 19 Apr 2012 12:16:52 -0500
User-agent: Mutt/1.5.21 (2010-09-15)

On Thu, Apr 19, 2012 at 11:56:28AM -0500, Richard Henderson wrote:
> On 04/19/2012 11:05 AM, Michael Roth wrote:
> > When linux-specific commands (including guest-fsfreeze-*) were consolidated
> > under defined(__linux__), we forgot to account for the case where
> > defined(__linux__) && !defined(FIFREEZE). As a result stubs are no longer
> > being generated on linux hosts that don't have FIFREEZE support. Fix
> > this.
> > 
> > Tested-by: Andreas Färber <address@hidden>
> > Reviewed-by: Luiz Capitulino <address@hidden>
> > Signed-off-by: Michael Roth <address@hidden>
> > ---
> >  qga/commands-posix.c |   36 ++++++++++++++++++++----------------
> >  1 files changed, 20 insertions(+), 16 deletions(-)
> 
> I know it moves more code around, but I think un-nesting CONFIG_FSFREEZE
> from within __linux__ is more logically correct.

Agreed, Luiz and I talked about doing this in a seperate patch. The main
ugliness is just that CONFIG_FSFREEZE is basically (__linux__ &&
FIFREEZE), so if we nest it as FIFREEZE instead of both it makes sense.
Then we generate stubs on (!__linux__ || !FIFREEZE).

But in the meantime we should apply the current patch since it's been
thoroughly tested/reviewed at this point and fixes the build issue.

> 
> 
> r~
> 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]