[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3] ARM: Exynos4210 IRQ: Introduce new IRQ gate
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v3] ARM: Exynos4210 IRQ: Introduce new IRQ gate functionality. |
Date: |
Fri, 20 Apr 2012 12:13:27 +0100 |
On 17 April 2012 06:41, Evgeny Voevodin <address@hidden> wrote:
> +static Property exynos4210_irq_gate_properties[] = {
> + DEFINE_PROP_UINT32("n_in", Exynos4210IRQGateState, n_in, 1),
> + DEFINE_PROP_END_OF_LIST(),
> +};
> +
> static const VMStateDescription vmstate_exynos4210_irq_gate = {
> .name = "exynos4210.irq_gate",
> - .version_id = 1,
> - .minimum_version_id = 1,
> - .minimum_version_id_old = 1,
> + .version_id = 2,
> + .minimum_version_id = 2,
> + .minimum_version_id_old = 2,
> .fields = (VMStateField[]) {
> - VMSTATE_UINT32_ARRAY(gpio_level, Exynos4210IRQGateState,
> - EXYNOS4210_IRQ_GATE_NINPUTS),
> + VMSTATE_UINT32(n_in, Exynos4210IRQGateState),
> + VMSTATE_VBUFFER_UINT32(level, Exynos4210IRQGateState, 1, NULL, 0,
> n_in),
> VMSTATE_END_OF_LIST()
n_in is constant, so you shouldn't need to save/restore it, right?
Otherwise looks good.
PS: 3 days is a bit eager to be sending pings :-) I'd suggest about
a week as the usual time to leave...
-- PMM
Re: [Qemu-devel] [PATCH v3] Exynos4210 IRQ Gate improvement, Evgeny Voevodin, 2012/04/19