Re: [Qemu-devel] [PATCH] Bug fix for #986241: spell env correctly

[Andreas Färber]

Am 22.04.2012 22:06, schrieb Peter Maydell:
> On 22 April 2012 20:56, Andreas Färber <address@hidden> wrote:
>> Commit ed120055c7f9b26b5707d3ceabbe5a3f06aaf937 (Implement PAPR VPA
>> functions for pSeries shared processor partitions) introduced the
>> register_dtl() function and typo "emv" as name of its argument.
>> This went unnoticed because the code in that function can access the
>> global variable "env" so that no build failure resulted.
>>
>> Fix the argument to read "env". Resolves LP#986241.
> 
> Incidentally, I had a quick look through that file and couldn't
> see any uses of 'env' outside of functions which pass it in --
> is it possible to drop the dyngen-exec.h include altogether?

A quick build test confirms that, yes. Blue's AREG0 series does not seem
to touch this file, so we could do it independently as a follow-up to
this one.

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg