Re: [Qemu-devel] [PATCH v3] ARM: Exynos4210 IRQ: Introduce new IRQ gate functionality.

[Evgeny Voevodin]

On 20.04.2012 15:51, Evgeny Voevodin wrote:
> On 20.04.2012 15:13, Peter Maydell wrote:
> > On 17 April 2012 06:41, Evgeny Voevodin<address@hidden> wrote:
> > > +static Property exynos4210_irq_gate_properties[] = {
> > > + DEFINE_PROP_UINT32("n_in", Exynos4210IRQGateState, n_in, 1),
> > > + DEFINE_PROP_END_OF_LIST(),
> > > +};
> > > +
> > > static const VMStateDescription vmstate_exynos4210_irq_gate = {
> > > .name = "exynos4210.irq_gate",
> > > - .version_id = 1,
> > > - .minimum_version_id = 1,
> > > - .minimum_version_id_old = 1,
> > > + .version_id = 2,
> > > + .minimum_version_id = 2,
> > > + .minimum_version_id_old = 2,
> > > .fields = (VMStateField[]) {
> > > - VMSTATE_UINT32_ARRAY(gpio_level, Exynos4210IRQGateState,
> > > - EXYNOS4210_IRQ_GATE_NINPUTS),
> > > + VMSTATE_UINT32(n_in, Exynos4210IRQGateState),
> > > + VMSTATE_VBUFFER_UINT32(level, Exynos4210IRQGateState, 1, NULL, 0,
> > > n_in),
> > > VMSTATE_END_OF_LIST()
> > n_in is constant, so you shouldn't need to save/restore it, right?
>
> Oh, seems so. It's not changing during run-time.

Peter, wait, n_in is a property that board sets. So it should be 
saved/restored.

> > Otherwise looks good.
> >
> > PS: 3 days is a bit eager to be sending pings :-) I'd suggest about
> > a week as the usual time to leave...
>
> Ok, sorry :)
>
> > -- PMM


--
Kind regards,
Evgeny Voevodin,
Leading Software Engineer,
ASWG, Moscow R&D center, Samsung Electronics
e-mail: address@hidden