qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1/2] virtio: set guest_features before calling s


From: Michael S. Tsirkin
Subject: Re: [Qemu-devel] [PATCH 1/2] virtio: set guest_features before calling set_features callback, not after
Date: Mon, 23 Apr 2012 16:06:02 +0300
User-agent: Mutt/1.5.21 (2010-09-15)

On Mon, Apr 23, 2012 at 02:26:23PM +0300, Alon Levy wrote:
> We could drop the features parameter but that's a little more work and
> it's not really needed.
> 
> Signed-off-by: Alon Levy <address@hidden>

I think it's fine the way it is but if you want callbacks to use
vdev->guest_features remove the features parameter.

Having both is just confusing.


> ---
>  hw/virtio.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/virtio.c b/hw/virtio.c
> index 064aecf..aeddc81 100644
> --- a/hw/virtio.c
> +++ b/hw/virtio.c
> @@ -770,10 +770,10 @@ int virtio_set_features(VirtIODevice *vdev, uint32_t 
> val)
>      bool bad = (val & ~supported_features) != 0;
>  
>      val &= supported_features;
> +    vdev->guest_features = val;
>      if (vdev->set_features) {
>          vdev->set_features(vdev, val);
>      }
> -    vdev->guest_features = val;
>      return bad ? -1 : 0;
>  }
>  
> -- 
> 1.7.10
> 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]