[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/4] block: use Error mechanism instead of -errn
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH 1/4] block: use Error mechanism instead of -errno for block_job_create() |
|
Date: |
Mon, 23 Apr 2012 17:42:45 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1 |
Il 23/04/2012 17:39, Stefan Hajnoczi ha scritto:
> + stream_start(bs, base_bs, base, block_stream_cb, bs, errp);
> + if (error_is_set(errp)) {
> + return;
> }
This needs to be
Error *local_err = NULL;
stream_start(bs, base_bs, base, block_stream_cb, bs, &local_err);
if (local_err) {
error_propagate(errp, local_err);
return;
}
Otherwise looks good.
Paolo