Re: [Qemu-devel] [PATCH v2] pseries: Fix use of global CPU state

[Andreas Färber]

Am 23.04.2012 19:27, schrieb Peter Portante:
> Commit ed120055c7f9b26b5707d3ceabbe5a3f06aaf937 (Implement PAPR VPA
> functions for pSeries shared processor partitions) introduced the
> register_dtl() function and typo "emv" as name of its argument.

Mea culpa: deregister_dtl()

> This went unnoticed because the code in that function can access the
> global variable "env" so that no build failure resulted.
> 
> Fix the argument to read "env". Resolves LP#986241.
> 
> Signed-off-by: Peter Portante <address@hidden>

Acked-by: Andreas Färber <address@hidden>

Alex, could you please fix my above typo when applying to avoid a v3? :)

Thanks,
Andreas

> ---
>  hw/spapr_hcall.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/hw/spapr_hcall.c b/hw/spapr_hcall.c
> index 634763e..94bb504 100644
> --- a/hw/spapr_hcall.c
> +++ b/hw/spapr_hcall.c
> @@ -482,7 +482,7 @@ static target_ulong register_dtl(CPUPPCState *env, 
> target_ulong addr)
>      return H_SUCCESS;
>  }
>  
> -static target_ulong deregister_dtl(CPUPPCState *emv, target_ulong addr)
> +static target_ulong deregister_dtl(CPUPPCState *env, target_ulong addr)
>  {
>      env->dispatch_trace_log = 0;
>      env->dtl_size = 0;

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg