Re: [Qemu-devel] [PATCH] fix BCD mask for date (Solaris 2.5 guest hang fix)

[Artyom Tarasenko]

On Mon, Apr 23, 2012 at 7:34 PM, Andreas Färber <address@hidden> wrote:
> Am 23.04.2012 18:48, schrieb Artyom Tarasenko:
>> On Mon, Apr 23, 2012 at 5:18 PM, Andreas Färber <address@hidden> wrote:
>>> Ideally the patch would also indicate that it's about "m48t59: ".
>>
>> You mean, like "[PATCH,m48t59] fix BCD mask for date (Solaris 2.5
>> guest hang fix)" ?
>
> No, within [] it's not preserved for git. I meant like
> "[PATCH] m48t59: Fix BCD mask for date" or
> "[PATCH] hw/m48t59: Fix BCD mask for date" or something like that.
>
> Makes it easier to spot patches on the list that are of interest - in
> this case m48t59 affects ppc/PReP too, not just Solaris.

Right. But on the other hand, it makes obvious the use case it's
fixing. If you discover that the patch breaks PReP, and the code needs
to be changed, you'll immediately know what use case might be affected
by the change.

Also, what we currently have:
 git log --pretty=short hw/m48t59.c
shows that most commits (including the two previous ones) don't have
the m48t59 prefix.
Maybe we need a new coding convention for this?

Artyom

-- 
Regards,
Artyom Tarasenko

solaris/sparc under qemu blog: http://tyom.blogspot.com/search/label/qemu