[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/4] block: add optional 'speed' parameter to bl
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 0/4] block: add optional 'speed' parameter to block-stream |
Date: |
Mon, 23 Apr 2012 14:44:27 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1 |
On 04/23/2012 01:38 PM, Anthony Liguori wrote:
>>> I like the approach of adding a new optional parameter; that is a
>>> workable solution for libvirt (that is, libvirt can assume that if the
>>> spelling 'block-stream' is available, then so is the optional 'speed'
>>> parameter, if this patch is included in time for qemu 1.1).
>>
>> The optional parameter is fine for me too, but we recently had a
>> discussion where it was decided that we should add new commands instead
>> of extending existing ones.
>>
>> Anthony, I believe we're already taking that position, right?
>
> Correct. It's impossible to tell whether a given version of QEMU
> supports extra parameters if we just add them to existing commands.
Thankfully, block-stream is not an existing command, and we've already
created block-stream for qemu 1.1 as the new command that is explicitly
different from the block_stream of RHEL 6.2. Now is the time to get
this fix in, before we are stuck with bad semantics.
--
Eric Blake address@hidden +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH 2/4] block: use Error mechanism instead of -errno for block_job_set_speed(), (continued)
Re: [Qemu-devel] [PATCH 0/4] block: add optional 'speed' parameter to block-stream, Eric Blake, 2012/04/23
Re: [Qemu-devel] [PATCH 0/4] block: add optional 'speed' parameter to block-stream, Anthony Liguori, 2012/04/23
Re: [Qemu-devel] [PATCH 0/4] block: add optional 'speed' parameter to block-stream,
Eric Blake <=
Re: [Qemu-devel] [PATCH 0/4] block: add optional 'speed' parameter to block-stream, Luiz Capitulino, 2012/04/23