Re: [Qemu-devel] [PATCH 08/12 v13] target-i386: Add API to write cpu status to core file

[Wen Congyang]

At 04/24/2012 06:43 AM, Anthony Liguori Wrote:
> On 04/18/2012 07:55 AM, Wen Congyang wrote:
>> The core file has register's value. But it does not include all registers 
>> value.
>> Store the cpu status into QEMU note, and the user can get more information
>> from vmcore. If you change QEMUCPUState, please count up 
>> QEMUCPUSTATE_VERSION.
>>
>> Signed-off-by: Wen Congyang<address@hidden>
> 
> This breaks the build in the "it's fairly obvious you are only testing with
> --target-list=x86_64-softmmu" sort of way.  Please don't do that.  It only 
> takes
> a 30 minutes to do a full build (less with -jN) and saves me hours of 
> bisecting
> to figure out which patch in my queue caused the breakage.
> 
>   CC    alpha-softmmu/arch_init.o
> In file included from /home/anthony/git/qemu/target-alpha/cpu.h:294:0,
>                  from /home/anthony/git/qemu/qemu-common.h:123,
>                  from /home/anthony/git/qemu/monitor.h:4,
>                  from /home/anthony/git/qemu/arch_init.c:32:
> /home/anthony/git/qemu/cpu-all.h:577:1: error: expected identifier or ‘(’ 
> before
> ‘{’ token
> /home/anthony/git/qemu/cpu-all.h:574:19: error: ‘cpu_write_elf64_qemunote’
> declared ‘static’ but never defined [-Werror=unused-function]
> cc1: all warnings being treated as errors
> 
> make[1]: *** [arch_init.o] Error 1
> make: *** [subdir-alpha-softmmu] Error 2

Sorry, I donot do a full build. I will fix it.

Thanks
Wen Congyang

> 
> Regards,
> 
> Anthony Liguori
>