Re: [Qemu-devel] [PATCH] ISCSI: Add support for thin-provisioning via discard/UNMAP and bigger LUNs

[Paolo Bonzini]

Il 24/04/2012 10:02, ronnie sahlberg ha scritto:
> So ignore this patch for now. I will redo UNMAP in the patch to
> instead use the generic scsi function inside libiscsi.
> 
> That will serve the purpose to verify that the public API in libiscsi
> is sufficient for accessing the generic transport and
> secondly that will show a useful example on how to send CDB+data to
> and to receive data back from the generic function.
> 
> This generic API would be what a future virt-scsi->libiscsi
> integration would use anyway.

I will be on holiday from tomorrow to May 1, and I won't be able to send
a pull request today.  As I want to minimize the time I spend looking at
qemu-devel, :) I'll take this patch as is, since the new libiscsi
version is needed anyway for READ CAPACITY (16).

You could write a follow-up patch to teach iscsi.c about WRITE SAME(10)
and WRITE SAME(16) with the unmap bit set, and use generic CDB+data
functions for those.

Paolo