[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 09/14] usb-redir: An interface count of 0 is a valid
From: |
Gerd Hoffmann |
Subject: |
[Qemu-devel] [PATCH 09/14] usb-redir: An interface count of 0 is a valid value |
Date: |
Tue, 24 Apr 2012 17:51:26 +0200 |
From: Hans de Goede <address@hidden>
An interface-count of 0 happens when a device is in unconfigured state when
it gets redirected. So we should not use 0 to detect not having received
interface info from our peer.
Signed-off-by: Hans de Goede <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>
---
hw/usb/redirect.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/hw/usb/redirect.c b/hw/usb/redirect.c
index 94ab463..3e6e7e9 100644
--- a/hw/usb/redirect.c
+++ b/hw/usb/redirect.c
@@ -39,6 +39,7 @@
#include "hw/usb.h"
#define MAX_ENDPOINTS 32
+#define NO_INTERFACE_INFO 255 /* Valid interface_count always <= 32 */
#define EP2I(ep_address) (((ep_address & 0x80) >> 3) | (ep_address & 0x0f))
#define I2EP(i) (((i & 0x10) << 3) | (i & 0x0f))
@@ -970,7 +971,7 @@ static void usbredir_handle_destroy(USBDevice *udev)
static int usbredir_check_filter(USBRedirDevice *dev)
{
- if (dev->interface_info.interface_count == 0) {
+ if (dev->interface_info.interface_count == NO_INTERFACE_INFO) {
ERROR("No interface info for device\n");
goto error;
}
@@ -1134,7 +1135,7 @@ static void usbredir_device_disconnect(void *priv)
QTAILQ_INIT(&dev->endpoint[i].bufpq);
}
usb_ep_init(&dev->dev);
- dev->interface_info.interface_count = 0;
+ dev->interface_info.interface_count = NO_INTERFACE_INFO;
}
static void usbredir_interface_info(void *priv,
--
1.7.1
- [Qemu-devel] [PULL 00/14] usb patch queue, Gerd Hoffmann, 2012/04/24
- [Qemu-devel] [PATCH 02/14] usb-ehci: add missing usb_packet_init() call, Gerd Hoffmann, 2012/04/24
- [Qemu-devel] [PATCH 09/14] usb-redir: An interface count of 0 is a valid value,
Gerd Hoffmann <=
- [Qemu-devel] [PATCH 05/14] usb-host: don't dereference invalid iovecs, Gerd Hoffmann, 2012/04/24
- [Qemu-devel] [PATCH 06/14] usb-host: fix zero-length packets, Gerd Hoffmann, 2012/04/24
- [Qemu-devel] [PATCH 04/14] usb-storage: fix request canceling, Gerd Hoffmann, 2012/04/24
- [Qemu-devel] [PATCH 03/14] usb-ehci: Ensure frindex writes leave a valid frindex value, Gerd Hoffmann, 2012/04/24
- [Qemu-devel] [PATCH 01/14] usb-ehci: remove hack, Gerd Hoffmann, 2012/04/24
- [Qemu-devel] [PATCH 13/14] usb-uhci: update irq line on reset, Gerd Hoffmann, 2012/04/24
- [Qemu-devel] [PATCH 10/14] usb-redir: Reset device address and speed on disconnect, Gerd Hoffmann, 2012/04/24
- [Qemu-devel] [PATCH 08/14] usb-xhci: fix bit test, Gerd Hoffmann, 2012/04/24
- [Qemu-devel] [PATCH 11/14] usb-redir: Not finding an async urb id is not an error, Gerd Hoffmann, 2012/04/24
- [Qemu-devel] [PATCH 12/14] usb: add serial number generator, Gerd Hoffmann, 2012/04/24