Re: [Qemu-devel] [PATCH v2 3/6] block: change block-job-set-speed argument from 'value' to 'speed'

[Luiz Capitulino]

On Tue, 24 Apr 2012 09:03:06 -0600
Eric Blake <address@hidden> wrote:

> > +++ b/hmp-commands.hx
> > @@ -85,8 +85,8 @@ ETEXI
> >  
> >      {
> >          .name       = "block_job_set_speed",
> > -        .args_type  = "device:B,value:o",
> > -        .params     = "device value",
> > +        .args_type  = "device:B,speed:o",
> > +        .params     = "device speed",
> 
> For that matter, can the :o type _ever_ usefully allow negative values,
> or is it always an unsigned calculation?

It does allow for negative values. As an example, migrate_set_speed rounds
the value to zero if it's negative.