Re: [Qemu-devel] [PATCH] xtensa, hw: remove unnecessary include of dyngen-exec.h

[Peter Portante]

On 04/25/2012 04:30 PM, Andreas Färber wrote:
> Am 25.04.2012 20:47, schrieb Peter Portante:
> > Signed-off-by: Peter Portante<address@hidden>
> > ---
> >   hw/spapr_hcall.c |    1 -
> >   xtensa-semi.c    |    1 -
> >   2 files changed, 0 insertions(+), 2 deletions(-)
> >
> > diff --git a/hw/spapr_hcall.c b/hw/spapr_hcall.c
> > index 94bb504..88c1fab 100644
> > --- a/hw/spapr_hcall.c
> > +++ b/hw/spapr_hcall.c
> > @@ -1,6 +1,5 @@
> >   #include "sysemu.h"
> >   #include "cpu.h"
> > -#include "dyngen-exec.h"
> >   #include "qemu-char.h"
> >   #include "sysemu.h"
> >   #include "qemu-char.h"
> Careful! This part depends on http://patchwork.ozlabs.org/patch/154522/
> getting applied first - I was surprised that you didn't send it as a
> two-patch series alongside the "emv" v2. (cc'ing qemu-ppc)
Ugh, thanks for pointing that out. I should have done that. I was too 
focused on the bug first.

I'll re-submit this first change once the above patch is in the tree.
> > diff --git a/xtensa-semi.c b/xtensa-semi.c
> > index 5754b77..8c97a02 100644
> > --- a/xtensa-semi.c
> > +++ b/xtensa-semi.c
> > @@ -30,7 +30,6 @@
> >   #include<string.h>
> >   #include<stddef.h>
> >   #include "cpu.h"
> > -#include "dyngen-exec.h"
> >   #include "helpers.h"
> >   #include "qemu-log.h"
> This part is independent of the above. If you rebase it and split it off
> into its own patch (e.g., git checkout -p) then Max can apply it to his
> xtensa queue already.
Thanks, I'll do that.

-peter

> Andreas