[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 6/9] qxl: cleanup s/__FUNCTION__/__func__/
|
From: |
Andreas Färber |
|
Subject: |
Re: [Qemu-devel] [PATCH 6/9] qxl: cleanup s/__FUNCTION__/__func__/ |
|
Date: |
Thu, 26 Apr 2012 11:17:40 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120328 Thunderbird/11.0.1 |
Am 26.04.2012 11:11, schrieb Peter Maydell:
> On 26 April 2012 09:18, Andreas Färber <address@hidden> wrote:
>> If you have some spare time, you could do this all over the code base.
>> While not wrong in gcc, it invites people to copy from the old examples.
>
> Doesn't seem worth the effort to me. checkpatch warns about it so
> it's not that likely that we'll get new code using it.
We recently did in some KVM thread (after I suggested using __func__).
What does this tell us? People either don't run checkpatch.pl or
checkpatch.pl is buggy or, more likely, both. ;)
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- Re: [Qemu-devel] [RFC] qxl: don't panic on phys2virt, Gerd Hoffmann, 2012/04/24
- [Qemu-devel] [PATCH 1/9] hw/qxl.c: qxl_phys2virt: replace panics with guest_bug, Alon Levy, 2012/04/25
- [Qemu-devel] [PATCH 2/9] qxl: check for NULL return from qxl_phys2virt, Alon Levy, 2012/04/25
- [Qemu-devel] [PATCH 3/9] qxl: replace panic with guest bug in qxl_track_command, Alon Levy, 2012/04/25
- [Qemu-devel] [PATCH 4/9] qxl: fix > 80 chars line, Alon Levy, 2012/04/25
- [Qemu-devel] [PATCH 5/9] qxl: don't abort on guest trigerrable ring indices mismatch, Alon Levy, 2012/04/25
- [Qemu-devel] [PATCH 6/9] qxl: cleanup s/__FUNCTION__/__func__/, Alon Levy, 2012/04/25
- [Qemu-devel] [PATCH 7/9] qxl: interface_notify_update: remove guest trigerrable abort, Alon Levy, 2012/04/25
- [Qemu-devel] [PATCH 8/9] qxl: qxl_add_memslot: remove guest trigerrable panics, Alon Levy, 2012/04/25
- [Qemu-devel] [PATCH 9/9] qxl: ioport_write: remove guest trigerrable abort, Alon Levy, 2012/04/25
- Re: [Qemu-devel] [PATCH 1/9] hw/qxl.c: qxl_phys2virt: replace panics with guest_bug, Gerd Hoffmann, 2012/04/26