qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] configure: Don't build bsd-user on Mac OS X by


From: Andreas Färber
Subject: Re: [Qemu-devel] [PATCH] configure: Don't build bsd-user on Mac OS X by default
Date: Thu, 26 Apr 2012 14:50:12 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120328 Thunderbird/11.0.1

Am 26.04.2012 12:30, schrieb Bernhard Walle:
> Am 26.04.12 11:57, schrieb Andreas Färber:
>> Fixes the build when combined with the drop of darwin-user.
>> Enthusiasts can still try building it using --enable-bsd-user.
>>
>> Signed-off-by: Andreas Färber <address@hidden>
>> Cc: Bernhard Walle <address@hidden>
> 
> Thanks. I already stumbled over this when trying to test your
> uint16 fixes (they work for me, BTW).

In that case please add an appropriate tag (e.g., Tested-by) as reply
there (best with info on what architecture and OS version you tested).
Otherwise there's no telling whether no one looked at it, and they will
bitrot again like in January and before that. Patch review and reacting
to patch reviews are the weak spot of Mac OS X host support, sadly.

If you add an Acked-by to this one, I can send a PULL for this and
darwin-user removal right away. uint16 touches all hosts and virtually
all guests so needs more review than the Darwin-only changes.

Regards,
Andreas



reply via email to

[Prev in Thread] Current Thread [Next in Thread]