qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH V3 12/13] hw/sd.c: introduce SD card "device-id"


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH V3 12/13] hw/sd.c: introduce SD card "device-id" property
Date: Sat, 28 Apr 2012 16:25:27 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1

Il 27/04/2012 18:52, Igor Mitsyanko ha scritto:
>>>
>> The other block device models use a property "drive" for connecting to a
>> block backend, usually via DEFINE_BLOCK_PROPERTIES().  Why is it
>> necessary for sd.c to be different?
>>
> 
> SD card is not an instance of TYPE_DEVICE, we cant set a pointer to 
> BlockDriverState as a property of TYPE_SD_CARD object. I think in the
> future we will just have TYPE_SD_CARD/child<TYPE_BLOCK_DRIVER_STATE> 
> or TYPE_SD_CARD/link<TYPE_BLOCK_DRIVER_STATE>, but now "device_id" 
> property seems like a nice solution.

I agree---however, calling it "drive" for consistency is nicer.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]