Re: [Qemu-devel] [PATCH v2] sdl: Add QEMU mascot icon for use with SDL

[Andreas Färber]

Am 23.04.2012 22:11, schrieb Stefan Weil:
> Am 13.04.2012 22:24, schrieb Stefan Weil:
>> This is a bitmap file (32x32x4) derived from the official QEMU mascot
>> (which was designed by Benoît Canet). I stripped the text from the SVG
>> to get a nearly square image and converted the result to BMP without
>> any manual optimization.
>>
>> The bitmap is currently used by QEMU's SDL interface and replaces the
>> default X icon.
>>
>> v2: Add qemu-icon.bmp to Makefile.
>>
>> Signed-off-by: Stefan Weil <address@hidden>
>> ---
>> Makefile | 1 +
>> pc-bios/qemu-icon.bmp | Bin 0 -> 630 bytes
>> 2 files changed, 1 insertions(+), 0 deletions(-)
>> create mode 100644 pc-bios/qemu-icon.bmp
[...]
> I'm a bit surprised that there was no reaction on this patch
> (neither on version 1 nor on version 2).

It looks kind of ugly in GNOME3, where it is scaled up to some other
resolution in the top bar. IIRC Windows 7 uses 64x64 max, Mac OS X
128x128 max, GNOME 48x48(?).

When we add icons for Gtk+ and Cocoa we might also want to rename the
file to indicate size and/or purpose (e.g., qemu-sdl-icon.bmp /
qemu-32x32-icon.bmp).

For Windows, wouldn't it be a better idea to use the multi-resolution
.ico format through version.rc and to avoid the generic SDL icon being
used? Don't see that being set up in this patch - #ifdef it out there?

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg