Re: [Qemu-devel] [PATCH 11/14] qbus: move get_fw_dev_path to DeviceClass

[Anthony Liguori]

On 05/01/2012 02:34 PM, Andreas Färber wrote:
> Am 01.05.2012 20:18, schrieb Anthony Liguori:
> > It should have never been a bus method.
> >
> > Signed-off-by: Anthony Liguori<address@hidden>
> > ---
> [...]
> > diff --git a/hw/ide/qdev.c b/hw/ide/qdev.c
> > index 4a468f8..5044018 100644
> > --- a/hw/ide/qdev.c
> > +++ b/hw/ide/qdev.c
> > @@ -25,22 +25,13 @@
> >
> >   /* --------------------------------- */
> >
> > -static char *idebus_get_fw_dev_path(DeviceState *dev);
> > -
> >   #define TYPE_IDE_BUS "IDE"
> > -
> > -static void ide_bus_class_init(ObjectClass *klass, void *data)
> > -{
> > -    BusClass *k = BUS_CLASS(klass);
> > -
> > -    k->get_fw_dev_path = idebus_get_fw_dev_path;
> > -}
> > +#define IDE_BUS(obj) OBJECT_CHECK(IDEBus, (obj), TYPE_IDE_BUS)
>
> Move macro to preceding patch?
>
> Otherwise looks good.

Do you mean an independent patch?

Regards,

Anthony Liguori

> /-F