Re: [Qemu-devel] [PATCH 02/21] qom: add object_class_get_parent

[Andreas Färber]

Am 02.05.2012 13:30, schrieb Paolo Bonzini:
> This simple bit of functionality was missing and we'll need it soon,
> so add it.
> 
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
>  include/qemu/object.h |    8 ++++++++
>  qom/object.c          |   13 +++++++++++++
>  2 files changed, 21 insertions(+)
> 
> diff --git a/include/qemu/object.h b/include/qemu/object.h
> index d315dfa..063c817 100644
> --- a/include/qemu/object.h
> +++ b/include/qemu/object.h
> @@ -548,6 +548,14 @@ ObjectClass *object_class_dynamic_cast(ObjectClass 
> *klass,
>                                         const char *typename);
>  
>  /**
> + * object_class_get_parent:
> + * @klass: The class to obtain the parent for.
> + *
> + * Returns: The parent for @klass.

Here too we should indicate that this may return NULL (rather than
aborting). Other than that looks good.

Andreas

> + */
> +ObjectClass *object_class_get_parent(ObjectClass *klass);
> +
> +/**
>   * object_class_get_name:
>   * @klass: The class to obtain the QOM typename for.
>   *
[snip]

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg