[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] slirp: Untangle TCPOLEN_* from TCPOPT_*
|
From: |
Jan Kiszka |
|
Subject: |
Re: [Qemu-devel] [PATCH] slirp: Untangle TCPOLEN_* from TCPOPT_* |
|
Date: |
Wed, 02 May 2012 10:48:59 -0300 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
On 2012-05-02 10:40, Andreas Färber wrote:
> Am 02.05.2012 15:24, schrieb Paolo Bonzini:
>>> But that would leave Illumos broken.
>
> For the record, reverting would leave whatever Paolo was fixing broken
> but would restore Illumos.
>
>> I'd rather apply this one.
>>
>> Please do. The right solution for 1.2 is to understand the places in which
>> slirp cannot use netinet/tcp.h constants (the MSS for example), and
>> otherwise use that header.
>
> Jan, should I prepare a mechanical prefix addition as suggested by Blue?
> Should we apply this ugly-but-least-intrusive build fix? Or do you have
> any other preference or idea?
I'm fine with a minimal fix like you suggested. The renaming should
probably be applied to a broader scope. So it's an exercise to be done
systematically and without any hurry.
Jan
signature.asc
Description: OpenPGP digital signature