Re: [Qemu-devel] [PATCH] Fix legacy device aliases for s390

[Christian Borntraeger]

On 03/05/12 10:49, Alexander Graf wrote:
> 
> On 03.05.2012, at 10:47, Christian Borntraeger wrote:
> 
>> When qemu is called with -device virtio-serial/blk/net on s390, this alias
>> is translated to virtio-serial/blk/net-pci instead of s390, since these
>> drivers are first in the alias table.
>> Let the core code check if the driver exist, if not lets search further.
>> This fixes errors like:
>>
>> qemu-kvm: -device virtio-serial,id=virtio-serial0: Parameter 'driver'
>> expects device type
>>
>> Signed-off-by: Christian Borntraeger <address@hidden>
> 
> The usual old fix was to not even compile them in. Why are they in the alias 
> list in the s390 build now?

Huh? The aliases always worked for me when I compiled qemu myself for s390. 
This changed with

commit 6acbe4c6f18e7de00481ff30574262b58526de45
Author: Anthony Liguori <address@hidden>
Date:   Thu Dec 22 11:05:00 2011 -0600

    qdev: remove baked in notion of aliases (v2)

In other word v1.0 is fine, master is not. This looks like a regression, no?

Christian