Re: [Qemu-devel] [PATCH v3] vnc: disable VNC password authentication (security type 2) when in FIPS mode

[Daniel P. Berrange]

On Thu, May 03, 2012 at 05:00:45PM -0400, Paul Moore wrote:
> FIPS 140-2 requires disabling certain ciphers, including DES, which is used
> by VNC to obscure passwords when they are sent over the network.  The
> solution for FIPS users is to disable the use of VNC password auth when the
> host system is operating in FIPS mode.
> 
> This patch causes qemu to emit a syslog entry and a message to stderr when
> the host system is running in FIPS mode and a VNC password was specified on
> the commend line.  If the system is not running in FIPS mode, or is running
> in FIPS mode but VNC password authentication was not requested, qemu
> operates normally.
> 
> Signed-off-by: Paul Moore <address@hidden>

Reviewed-by: Dainel P. Berrange <address@hidden>

Looks good to me now.

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|