[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [SeaBIOS] [seabios patch 1/5] pci: init all devices
From: |
Kevin O'Connor |
Subject: |
Re: [Qemu-devel] [SeaBIOS] [seabios patch 1/5] pci: init all devices |
Date: |
Fri, 4 May 2012 09:15:46 -0400 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Fri, May 04, 2012 at 10:21:23AM +0200, Gerd Hoffmann wrote:
> seabios used to initialize root bus devices only, with this patch
> devices behind pci bridges are initialized too. This allows to boot
> from virtio devices behind pci bridges.
>
> Signed-off-by: Gerd Hoffmann <address@hidden>
> ---
> src/pciinit.c | 3 ---
> 1 files changed, 0 insertions(+), 3 deletions(-)
>
> diff --git a/src/pciinit.c b/src/pciinit.c
> index 25b04ac..6a7a0d2 100644
> --- a/src/pciinit.c
> +++ b/src/pciinit.c
> @@ -213,9 +213,6 @@ static void pci_bios_init_devices(void)
> {
> struct pci_device *pci;
> foreachpci(pci) {
> - if (pci_bdf_to_bus(pci->bdf) != 0)
> - // Only init devices on host bus.
> - break;
I think this will then assign an incorrect PCI_INTERRUPT_LINE value to
non root bus devices.
-Kevin
Re: [Qemu-devel] [SeaBIOS] [seabios patch 0/5] dynamic pci i/o windows, Alexey Korolev, 2012/05/06