qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1/3] monitor: remove unused do_info_trace


From: Lluís Vilanova
Subject: Re: [Qemu-devel] [PATCH 1/3] monitor: remove unused do_info_trace
Date: Mon, 07 May 2012 15:46:57 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux)

Harsh Prateek Bora writes:

> Going forward with simpletrace v2 variable size trace records, we cannot
> have a generic function to print trace event info and therefore this
> interface becomes invalid.

> As per Stefan Hajnoczi:

> "This command is only available from the human monitor.  It's not very
> useful because it historically hasn't been able to pretty-print events
> or show them in the right order (we use a ringbuffer but it prints
> them out from index 0).

> Therefore, I don't think we're under any obligation to keep this
> command around.  No one has complained about it's limitations - I
> think this is a sign that no one has used it.  I'd be okay with a
> patch that removes it."

> Ref: http://lists.gnu.org/archive/html/qemu-devel/2012-01/msg01268.html

Eliminating 'do_info_trace' makes 'st_print_trace' unused; so maybe it could
also be eliminated.


Lluis


> Signed-off-by: Harsh Prateek Bora <address@hidden>
> ---
>  monitor.c |   16 ----------------
>  1 files changed, 0 insertions(+), 16 deletions(-)

> diff --git a/monitor.c b/monitor.c
> index 8946a10..bebf864 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -812,13 +812,6 @@ static void do_info_cpu_stats(Monitor *mon)
>  }
>  #endif
 
> -#if defined(CONFIG_TRACE_SIMPLE)
> -static void do_info_trace(Monitor *mon)
> -{
> -    st_print_trace((FILE *)mon, &monitor_fprintf);
> -}
> -#endif
> -
>  static void do_trace_print_events(Monitor *mon)
>  {
>      trace_print_events((FILE *)mon, &monitor_fprintf);
> @@ -2585,15 +2578,6 @@ static mon_cmd_t info_cmds[] = {
>          .help       = "show roms",
>          .mhandler.info = do_info_roms,
>      },
> -#if defined(CONFIG_TRACE_SIMPLE)
> -    {
> -        .name       = "trace",
> -        .args_type  = "",
> -        .params     = "",
> -        .help       = "show current contents of trace buffer",
> -        .mhandler.info = do_info_trace,
> -    },
> -#endif
>      {
>          .name       = "trace-events",
>          .args_type  = "",
> -- 
> 1.7.1.1



-- 
 "And it's much the same thing with knowledge, for whenever you learn
 something new, the whole world becomes that much richer."
 -- The Princess of Pure Reason, as told by Norton Juster in The Phantom
 Tollbooth



reply via email to

[Prev in Thread] Current Thread [Next in Thread]