Re: [Qemu-devel] [PATCH 14/22] vscsi: avoid unwarranted strncpy

[David Gibson]

On Wed, May 09, 2012 at 11:23:58AM +0200, Jim Meyering wrote:
> From: Jim Meyering <address@hidden>
> 
> Don't use strncpy when the source string is known to fit
> in the destination buffer.  Use equivalent memcpy.
> We could even use strcpy, here, but some static analyzers
> warn about that, so don't add new uses.
> 
> Signed-off-by: Jim Meyering <address@hidden>

Acked-by: David Gibson <address@hidden>

\-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson