[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] qtest: Add floppy test
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH 2/2] qtest: Add floppy test |
Date: |
Thu, 10 May 2012 09:30:01 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1 |
Am 09.05.2012 19:11, schrieb Andreas Färber:
> Am 08.05.2012 17:51, schrieb Kevin Wolf:
>> Let's start with testing media change.
>>
>> Signed-off-by: Kevin Wolf <address@hidden>
>> ---
>> tests/Makefile | 2 +
>> tests/fdc-test.c | 186
>> ++++++++++++++++++++++++++++++++++++++++++++++++++++++
>> 2 files changed, 188 insertions(+), 0 deletions(-)
>> create mode 100644 tests/fdc-test.c
>>
>> diff --git a/tests/Makefile b/tests/Makefile
>> index 9988681..a7697bd 100644
>> --- a/tests/Makefile
>> +++ b/tests/Makefile
>> @@ -19,6 +19,7 @@ check-block-$(CONFIG_POSIX) += tests/qemu-iotests-quick.sh
>> # All QTests for now are POSIX-only, but the dependencies are
>> # really in libqtest, not in the testcases themselves.
>> check-qtest-i386-y = tests/rtc-test
>> +check-qtest-i386-y = tests/fdc-test
>
> $(EXESUF)?
>
>> check-qtest-x86_64-y = $(check-qtest-i386-y)
>> check-qtest-sparc-y = tests/m48t59-test$(EXESUF)
>> check-qtest-sparc64-y = tests/m48t59-test$(EXESUF)
>
> Or are these wrong?
I think we should add $(EXESUF) indeed. I copied the rtc-test line where
it's missing as well, so I'll send a patch on top that fixes both.
Kevin