[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] kvm/apic: correct short memset
From: |
Jan Kiszka |
Subject: |
Re: [Qemu-devel] [PATCH 1/2] kvm/apic: correct short memset |
Date: |
Thu, 10 May 2012 14:28:01 -0300 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
On 2012-05-10 13:19, Jim Meyering wrote:
> From: Jim Meyering <address@hidden>
>
> kvm_put_apic_state's attempt to clear *kapic before setting its
> bits cleared sizeof(void*) bytes (no more than 8) rather than the
> intended 1024 (KVM_APIC_REG_SIZE) bytes. Spotted by coverity.
>
> Signed-off-by: Jim Meyering <address@hidden>
> ---
> hw/kvm/apic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/kvm/apic.c b/hw/kvm/apic.c
> index ffe7a52..a0ab503 100644
> --- a/hw/kvm/apic.c
> +++ b/hw/kvm/apic.c
> @@ -29,7 +29,7 @@ void kvm_put_apic_state(DeviceState *d, struct
> kvm_lapic_state *kapic)
> APICCommonState *s = DO_UPCAST(APICCommonState, busdev.qdev, d);
> int i;
>
> - memset(kapic, 0, sizeof(kapic));
> + memset(kapic, 0, sizeof(*kapic));
> kvm_apic_set_reg(kapic, 0x2, s->id << 24);
> kvm_apic_set_reg(kapic, 0x8, s->tpr);
> kvm_apic_set_reg(kapic, 0xd, s->log_dest << 24);
Yep, that's what I actually meant...
Thanks,
Jan
--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux