Re: [Qemu-devel] [PATCH next v2 34/74] omap: Use cpu_arm_init() to store ARMCPU in omap_mpu_state_s

[Peter Maydell]

On 10 May 2012 01:14, Andreas Färber <address@hidden> wrote:
> Fix tab indentations of comments, add braces, use cpu_reset().
>
> Signed-off-by: Andreas Färber <address@hidden>
> ---
>  hw/nseries.c  |    6 +++---
>  hw/omap.h     |    2 +-
>  hw/omap1.c    |   20 +++++++++++---------
>  hw/omap2.c    |    8 ++++----
>  hw/omap_sx1.c |    2 +-
>  hw/palm.c     |    2 +-
>  6 files changed, 21 insertions(+), 19 deletions(-)

There are some structs here which use the name 'cpu' for
a 'struct omap_mpu_state_s *', which leads to ugliness
like s->cpu->cpu->env. (We shouldn't be trying to fix that
here, just a passing comment.)

Acked-by: Peter Maydell <address@hidden>

(For the avoidance of doubt, acked-by for me means "I've
looked at this patch and it looks generally but I have not
tested it or otherwise given it the more detailed scrutiny
I would for a reviewed-by tag".)

-- PMM