Re: [Qemu-devel] [PATCH 4/4, master+QEMU 1.1] sun4u: implement interrupt clearing registers

[Blue Swirl]

On Sat, May 12, 2012 at 12:38 PM, Andreas Färber <address@hidden> wrote:
> Am 12.05.2012 14:32, schrieb Blue Swirl:
>> On Sat, May 12, 2012 at 11:56 AM, Andreas Färber <address@hidden> wrote:
>>> Am 12.05.2012 11:15, schrieb Artyom Tarasenko:
>>>> Implement registers for clearing OBIO and PCI interrupts
>>>>
>>>> Signed-off-by: Artyom Tarasenko <address@hidden>
>>>
>>> Implementing new registers is a feature, not a 1.1 bugfix...
>>> Many of us would like to get patches committed and have to wait.
>>
>> Those 12 trivial lines in Sparc64 specific code won't destabilize
>> anything. Two wrongs do not make one right, but several non-bug fix
>> patches have been committed since start of hard freeze. Including
>> yours.
>
> Which do you mean? You have not applied nor reviewed my pending sparc
> patches (and I don't expect you to apply them). I've only supplied
> bugfix and cleanup patches for 1.1 that I'm aware of.

For example
f5df5baf11a32ae6a669ac945625d1c3e4deb76d cpu: Update documentation and comment
aabfd88d5e1ec0878aa70076c3de1859614671f4 configure: Reindent VirtFS check

Both are nice, trivial patches, most certainly they don't implement
any registers and the release will be better with those included, but
they are not bug fixes.

>
> Andreas
>
> --
> SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
> GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg