[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 2/2] Split fdd devices off the floppy contro
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [RFC PATCH 2/2] Split fdd devices off the floppy controller |
Date: |
Mon, 14 May 2012 14:09:00 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1 |
Am 14.05.2012 13:58, schrieb Andreas Färber:
> Am 14.05.2012 10:47, schrieb Kevin Wolf:
>> Am 11.05.2012 17:22, schrieb Markus Armbruster:
>>> For historical reasons, and unlike other block devices, our floppy
>>> devices isa-fdc, sysbus-fdc and SUNW,fdtwo integrate the controller
>>> and the drive(s) in a single qdev. This makes them weird: we need
>>> -global to set up floppy drives, unlike every other optional device.
>>
>> I like the idea of splitting the drives from the controller. In fact, I
>> think we could even try to split them into a separate hw/fdd.c
>
> Seconded, however that might make the patch harder to read due to the
> code movements.
I didn't mean that we should do it in this patch, of course, but as a
second step.
Kevin
Re: [Qemu-devel] [RFC PATCH 0/2] Split fdd devices off the floppy controller, Markus Armbruster, 2012/05/11