[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qemu-ga: guest-shutdown: use only async-signal-
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH] qemu-ga: guest-shutdown: use only async-signal-safe functions |
|
Date: |
Mon, 14 May 2012 14:01:26 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 |
On 05/14/2012 01:59 PM, Luiz Capitulino wrote:
>>>> I'll declare it then.
>>>
>>> -Wredundant-decls doesn't like it:
>>>
>>> /home/lcapitulino/work/src/qmp-unstable/qga/commands-posix.c:38:15:
>>> warning: redundant redeclaration of ‘environ’ [-Wredundant-decls]
>>> /usr/include/unistd.h:546:15: note: previous declaration of ‘environ’ was
>>> here
>>> LINK qemu-ga
>
> What's the worst case if we leave it as is? The build will brake if environ
> ends up not being declared by some arch, right? In that case we could leave it
> as is and fix it when it brakes :)
Yep, which is precisely why I added my reviewed-by to v2.
--
Eric Blake address@hidden +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature