Re: [Qemu-devel] [PATCH 1.1] tests: Add rtc-test (fix test regression)

[Andreas Färber]

Am 15.05.2012 18:19, schrieb Stefan Weil:
> Commit 93e9eb6808c886f5f1c903b7ced1eed65de2ba39 added fdc-test,
> but accidentally removed rtc-test because check-qtest-i386-y was
> not enhanced but set twice.
> 
> This patch adds rtc-test again (and sorts both tests alphabetically).
> 
> Signed-off-by: Stefan Weil <address@hidden>

Reviewed-by: Andreas Färber <address@hidden>

I wonder though if it might be better to always just use += because
especially an alphabetical order risks us introducing the same fault again.

Andreas

> ---
>  tests/Makefile |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/Makefile b/tests/Makefile
> index f1b317a..ab7f667 100644
> --- a/tests/Makefile
> +++ b/tests/Makefile
> @@ -18,8 +18,8 @@ check-block-$(CONFIG_POSIX) += tests/qemu-iotests-quick.sh
>  
>  # All QTests for now are POSIX-only, but the dependencies are
>  # really in libqtest, not in the testcases themselves.
> -check-qtest-i386-y = tests/rtc-test$(EXESUF)
>  check-qtest-i386-y = tests/fdc-test$(EXESUF)
> +check-qtest-i386-y += tests/rtc-test$(EXESUF)
>  check-qtest-x86_64-y = $(check-qtest-i386-y)
>  check-qtest-sparc-y = tests/m48t59-test$(EXESUF)
>  check-qtest-sparc64-y = tests/m48t59-test$(EXESUF)

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg