|
From: | Zhi Hui Li |
Subject: | Re: [Qemu-devel] [PATCH 2/3 v6] Replace bdrv_* to bdrv_aio_* functions in DMA mode in fdc.c |
Date: | Wed, 16 May 2012 16:23:19 +0800 |
User-agent: | Mozilla/5.0 (X11; Linux i686; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 |
On 2012年05月15日 17:38, Paolo Bonzini wrote:
Il 15/05/2012 11:33, Kevin Wolf ha scritto:which blindly overwrites status2. Hence the new code was not written based on it. However, the new code is untested as far as I know.In the thread of an earlier version of this series, I said that a qtest for floppy is required. This only confirms it.The problem with writing a qtest is that the spec is incredibly complex and obscure. It's probably even better to rip out code that cannot be tested properly, so you don't have to test it at all... (Mostly tongue-in-cheek of course. A qtest for basic read/write in PIO and DMA modes is indeed a very good idea). Paolo
Yes , I think maybe Paolo is right. Because the spec is incredibly complex and obscure and I am newer.To write the whole code's qtest beyond my ability. I am afraid I can't finish it. so I want only do a qtest about basic read/write in PIO
and DMA modes. I don't know whether it is OK.(I don't know whether we can use qtest to replace the real test, especially on PIO mode 's test.)
Thank you very much.
[Prev in Thread] | Current Thread | [Next in Thread] |