[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1.1] tests: Add rtc-test (fix test regression)
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-devel] [PATCH 1.1] tests: Add rtc-test (fix test regression) |
|
Date: |
Wed, 16 May 2012 13:00:31 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1 |
Am 16.05.2012 06:07, schrieb Andreas Färber:
> Am 15.05.2012 18:19, schrieb Stefan Weil:
>> Commit 93e9eb6808c886f5f1c903b7ced1eed65de2ba39 added fdc-test,
>> but accidentally removed rtc-test because check-qtest-i386-y was
>> not enhanced but set twice.
>>
>> This patch adds rtc-test again (and sorts both tests alphabetically).
>>
>> Signed-off-by: Stefan Weil <address@hidden>
>
> Reviewed-by: Andreas Färber <address@hidden>
>
> I wonder though if it might be better to always just use += because
> especially an alphabetical order risks us introducing the same fault again.
Yes, I think that would be better.
Kevin