[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Xen-devel] [PATCH V11 3/8] Introduce XenHostPCIDevice
From: |
Konrad Rzeszutek Wilk |
Subject: |
Re: [Qemu-devel] [Xen-devel] [PATCH V11 3/8] Introduce XenHostPCIDevice to access a pci device on the host. |
Date: |
Wed, 16 May 2012 07:24:45 -0400 |
User-agent: |
Mutt/1.5.9i |
On Tue, Apr 03, 2012 at 04:32:38PM +0100, Anthony PERARD wrote:
> Signed-off-by: Anthony PERARD <address@hidden>
Looks good, thought I've just couple of tiny comments:
> +#define XEN_HOST_PCI_RESSOURCE_BUFFER_SIZE 512
You might want a comment explaining why 512, and not
a more precise number like 741.
> +{
.. snip..
> + do {
> + rc = read(fd, &buf, sizeof (buf) - 1);
> + if (rc < 0 && errno != EINTR) {
> + rc = -errno;
> + goto out;
> + }
> + } while (rc < 0);
Ok, you read it in. Maybe my 'wc' magic is gone, but this
is what I get:
address@hidden 0000:00:02.0]# cat resource | wc -c
741
.. snip..
> +#define XEN_HOST_PCI_GET_VALUE_BUFFER_SIZE 42
The answer to the life? Can you provide a comment explaining
the reason why it is 42, please?
> +static int xen_host_pci_get_value(XenHostPCIDevice *d, const char *name,
> + unsigned int *pvalue, int base)
> +{
- Re: [Qemu-devel] [Xen-devel] [PATCH V11 3/8] Introduce XenHostPCIDevice to access a pci device on the host.,
Konrad Rzeszutek Wilk <=