[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/4] Introduce a new hotplug state: Force eject.
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH 1/4] Introduce a new hotplug state: Force eject. |
Date: |
Wed, 16 May 2012 19:25:44 +0300 |
On Wed, May 16, 2012 at 05:52:17PM +0200, Paolo Bonzini wrote:
> Il 16/05/2012 15:20, Michael S. Tsirkin ha scritto:
> >>> Because it's missing the object_unparent done by qdev_unplug. Does
> >>> object_unparent+qdev_free work? (I believe object_unparent should be
> >>> done by qdev_free rather than qdev_unplug, but that's something for 1.2).
> >>
> >> Cool, this seems to work fine. Thanks.
> >>
> >> I'll test a bit more and resend a patch with only
> >> object_unparent+qdev_free.
> >
> > Separately it was suggested to make qdev_free do object_unparent
> > automatically. Anthony is yet to respond.
>
> Yes, but for 1.1 this Xen-only patch would be nice.
>
> Paolo
No sure which this patch is meant, the force eject is not a good idea.
Freeing directly from Xen is fine.
--
MST
- [Qemu-devel] [PATCH 1/4] Introduce a new hotplug state: Force eject., (continued)
- [Qemu-devel] [PATCH 1/4] Introduce a new hotplug state: Force eject., Anthony PERARD, 2012/05/15
- Re: [Qemu-devel] [PATCH 1/4] Introduce a new hotplug state: Force eject., Stefano Stabellini, 2012/05/15
- Re: [Qemu-devel] [PATCH 1/4] Introduce a new hotplug state: Force eject., Michael S. Tsirkin, 2012/05/15
- Re: [Qemu-devel] [PATCH 1/4] Introduce a new hotplug state: Force eject., Stefano Stabellini, 2012/05/16
- Re: [Qemu-devel] [PATCH 1/4] Introduce a new hotplug state: Force eject., Anthony PERARD, 2012/05/16
- Re: [Qemu-devel] [PATCH 1/4] Introduce a new hotplug state: Force eject., Paolo Bonzini, 2012/05/16
- Re: [Qemu-devel] [PATCH 1/4] Introduce a new hotplug state: Force eject., Anthony PERARD, 2012/05/16
- Re: [Qemu-devel] [PATCH 1/4] Introduce a new hotplug state: Force eject., Michael S. Tsirkin, 2012/05/16
- Re: [Qemu-devel] [PATCH 1/4] Introduce a new hotplug state: Force eject., Paolo Bonzini, 2012/05/16
- Re: [Qemu-devel] [PATCH 1/4] Introduce a new hotplug state: Force eject.,
Michael S. Tsirkin <=
- Re: [Qemu-devel] [PATCH 1/4] Introduce a new hotplug state: Force eject., Anthony Liguori, 2012/05/16
- Re: [Qemu-devel] [PATCH 1/4] Introduce a new hotplug state: Force eject., Michael S. Tsirkin, 2012/05/16
[Qemu-devel] [PATCH 3/4] pci: Add force_unplug callback., Anthony PERARD, 2012/05/15
Re: [Qemu-devel] [PATCH 1.1 0/4] Xen: Fix PV-on-HVM, Anthony Liguori, 2012/05/15
Re: [Qemu-devel] [PATCH 1.1 0/4] Xen: Fix PV-on-HVM, Stefano Stabellini, 2012/05/15
Re: [Qemu-devel] [PATCH 1.1 0/4] Xen: Fix PV-on-HVM, Michael S. Tsirkin, 2012/05/15