[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 4/7] RTC: Add divider reset support
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH v6 4/7] RTC: Add divider reset support |
|
Date: |
Thu, 17 May 2012 12:29:29 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 |
Il 17/05/2012 04:28, Zhang, Yang Z ha scritto:
>
> +static int32_t divider_reset;
This must be a variable inside RTCState.
The remark about inlining rtc_set_offset applies here as well.
Paolo
> +static inline bool rtc_running(RTCState *s)
> +{
> + return (!(s->cmos_data[RTC_REG_B] & REG_B_SET) &&
> + (s->cmos_data[RTC_REG_A] & 0x70) <= 0x20);
> +}
> +