Re: [Qemu-devel] [PATCH v2] qemu-img: Implement 'diff' operation.

[Richard W.M. Jones]

On Thu, May 17, 2012 at 09:15:08AM -0600, Eric Blake wrote:
> On 05/17/2012 08:57 AM, Richard W.M. Jones wrote:
> > +DEF("diff", img_diff,
> > +    "diff [-F backing_fmt] -b backing_file [-f fmt] [-O output_fmt] [-o 
> > options] filename output_filename")
> > +STEXI
> > address@hidden diff [-F @var{backing_fmt}] -b @var{backing_file} [-f 
> > @var{fmt}] [-O @var{output_fmt}] [-o @var{options}] @var{filename} 
> > @var{output_filename}
> 
> Why the difference in ordering between -o and -O?

I though it looked more logical, but I can swap them around too if you
think it's better.

> > +
> > +    if (argc - optind != 2) {
> > +        error_report("The input and output filenames must be supplied");
> > +        return 1;
> 
> Error is misleading if argc > optind+2.

OK will fix.

I'll rework the num_sectors thing in v3.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
virt-p2v converts physical machines to virtual machines.  Boot with a
live CD or over the network (PXE) and turn machines into Xen guests.
http://et.redhat.com/~rjones/virt-p2v