qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] Proposal for extensions of block job commands in QEMU 1


From: Kevin Wolf
Subject: Re: [Qemu-devel] Proposal for extensions of block job commands in QEMU 1.2
Date: Mon, 21 May 2012 16:17:30 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1

Am 21.05.2012 16:10, schrieb Anthony Liguori:
> On 05/21/2012 08:59 AM, Luiz Capitulino wrote:
>> On Fri, 18 May 2012 19:08:42 +0200
>> Paolo Bonzini<address@hidden>  wrote:
>>
>>> Modified QMP commands
>>> =====================
>>
>> As we have discussed on the ML, we're not going to extend QMP commands.
>>
>> I understand your reasoning, and since the beginning I thought this was
>> something useful to do, but we've already settled for not doing this.
>>
>> I also think that we shouldn't have exceptions, as in practice this means
>> we're extending commands anyway. So either, we do it or we don't.
> 
> Well, I think we should ask ourselves the following question:
> 
> How would a client figure out if the new options are available?
> 
> This is the primary reason for not extending existing commands.

I agree that trying out if an optional argument is accepted or not isn't
a nice solution, even though it works and is probably better than adding
block-stream-2, ..., block-stream-7.

Didn't you say a while ago that adding a command that would return the
JSON schema wouldn't be all that hard? Maybe it's the right time to
implement it for 1.2.

Kevin



reply via email to

[Prev in Thread] Current Thread [Next in Thread]