Re: [Qemu-devel] [PATCH v2 2/3] Add event notification for guest balloon changes

[Amit Shah]

On (Mon) 21 May 2012 [20:50:55], Daniel P. Berrange wrote:
> On Tue, May 22, 2012 at 01:14:59AM +0530, Amit Shah wrote:
> > On (Mon) 21 May 2012 [17:59:52], Daniel P. Berrange wrote:
> > > From: "Daniel P. Berrange" <address@hidden>
> > > 
> > > After setting a balloon target value, applications have to
> > > continually poll 'query-balloon' to determine whether the
> > > guest has reacted to this request. The virtio-balloon backend
> > > knows exactly when the guest has reacted though, and thus it
> > > is possible to emit a JSON event to tell the mgmt application
> > > whenever the guest balloon changes.
> > > 
> > > This introduces a new 'qemu_balloon_change()' API which is
> > 
> > I prefer qemu_balloon_changed(), it is clearer that this is called
> > after a balloon value change.  qemu_balloon_change() can be taken to
> > mean the function is called as a response the the monitor 'balloon'
> > command.
> 
> Happy to change this.
> 
> > > +BALLOON_CHANGE
> > > +----------
> > 
> > similarly, this can be BALLOON_CHANGED
> 
> For the sake of consistency with the existing RTC_CHANGE event, I prefer
> the naming I already have.

OK, thinking about it, it seems alright for this to remain
BALLOON_CHANGE, as it's an event that originates from qemu for mgmt
apps, so there isn't ambiguity about it.

Maybe others can chime in?

                Amit