qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] Weird iscsi/fd-event issue since recent merge of event


From: Michael Tokarev
Subject: Re: [Qemu-devel] Weird iscsi/fd-event issue since recent merge of event system changes
Date: Tue, 22 May 2012 20:31:32 +0400
User-agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:10.0.3) Gecko/20120329 Icedove/10.0.3

On 22.05.2012 14:03, ronnie sahlberg wrote:
[]
>>> Doh, now I remember.  Whenever you change the aio handlers you need to
>>> call qemu_notify_event() afterwards, if the handler may fire right away.
>>
>> Thanks.  I just confirmed that qemu_notify_event() fixes the issue.
>> Ill send a patch that uses qemu_notify_event() and a comment why this is 
>> needed.

When I were writing network block driver I tried to not call 
qemu_aio_set_fd_handler()
unless absolutely necessary -- that is, trying to write as much as possible till
the next write returns EAGAIN, or to read till the next read returns EAGAIN.  
This
way there's no need to call qemu_notify_event().  FWIW.

/mjt



reply via email to

[Prev in Thread] Current Thread [Next in Thread]