Re: [Qemu-devel] [PATCH v7 2/2] PCI: acpiphp: remove all functions in slot, even without ACPI _EJx

[Yinghai Lu]

On Tue, May 22, 2012 at 10:15 PM, Amos Kong <address@hidden> wrote:
> Attached the v7,  test passed.

would be better to have break...

+static struct pci_dev *dev_in_slot(struct acpiphp_slot *slot)
+{
+       struct pci_bus *bus = slot->bridge->pci_bus;
+       struct pci_dev *dev;
+       int ret = NULL;
+
+       down_read(&pci_bus_sem);
+       list_for_each_entry(dev, &bus->devices, bus_list)
+               if (PCI_SLOT(dev->devfn) == slot->device)
+                       ret = pci_dev_get(dev);
+       up_read(&pci_bus_sem);
+
+       return ret;
+}

===>


+static struct pci_dev *dev_in_slot(struct acpiphp_slot *slot)
+{
+       struct pci_bus *bus = slot->bridge->pci_bus;
+       struct pci_dev *dev;
+       int ret = NULL;
+
+       down_read(&pci_bus_sem);
+       list_for_each_entry(dev, &bus->devices, bus_list)
+               if (PCI_SLOT(dev->devfn) == slot->device) {
+                       ret = pci_dev_get(dev);
+                      break;
+              }
+       up_read(&pci_bus_sem);
+
+       return ret;
+}