[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 05/21] qom: assert that public types have a non-
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH 05/21] qom: assert that public types have a non-NULL parent field |
Date: |
Wed, 23 May 2012 19:01:16 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120421 Thunderbird/12.0 |
Am 02.05.2012 14:35, schrieb Andreas Färber:
> Am 02.05.2012 13:30, schrieb Paolo Bonzini:
>> This protects against unwanted effects of changing TYPE_OBJECT from
>> NULL to a string. Suggested by Andreas Faerber.
>>
>> Signed-off-by: Paolo Bonzini <address@hidden>
>> ---
>> include/qemu/object.h | 1 -
>> qom/object.c | 14 ++++++++++----
>> 2 files changed, 10 insertions(+), 5 deletions(-)
>>
>> diff --git a/include/qemu/object.h b/include/qemu/object.h
>> index 9c49d99..ec2b382 100644
>> --- a/include/qemu/object.h
>> +++ b/include/qemu/object.h
>> @@ -527,7 +527,6 @@ const char *object_get_typename(Object *obj);
>> */
>> Type type_register_static(const TypeInfo *info);
>>
>> -#define type_register_static_alias(info, name) do { } while (0)
>
> Unrelated removal of unused code?
>
> Other than that
>
> Reviewed-by: Andreas Färber <address@hidden>
Split in two and applied to qom-next:
http://repo.or.cz/w/qemu/afaerber.git/shortlog/refs/heads/qom-next
/-F
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- [Qemu-devel] [PATCH 04/21] qom: make Object a type, (continued)
[Qemu-devel] [PATCH 05/21] qom: assert that public types have a non-NULL parent field, Paolo Bonzini, 2012/05/02
[Qemu-devel] [PATCH 07/21] qdev: fix -device foo,?, Paolo Bonzini, 2012/05/02
[Qemu-devel] [PATCH 08/21] qdev: use object_property_print in info qtree, Paolo Bonzini, 2012/05/02
[Qemu-devel] [PATCH 10/21] qdev: do not propagate properties to subclasses, Paolo Bonzini, 2012/05/02