[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1.1 0/2]: qemu-ga: fix build on openbsd
From: |
Michael Roth |
Subject: |
Re: [Qemu-devel] [PATCH 1.1 0/2]: qemu-ga: fix build on openbsd |
Date: |
Wed, 23 May 2012 17:02:39 -0500 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, May 23, 2012 at 06:25:36PM -0300, Luiz Capitulino wrote:
> On Wed, 23 May 2012 15:08:43 -0500
> Michael Roth <address@hidden> wrote:
>
> > On Wed, May 23, 2012 at 03:48:03PM -0300, Luiz Capitulino wrote:
> > > Build error found by buildbot:
> > >
> > > qga/commands-posix.c: In function 'qmp_guest_shutdown':
> > > qga/commands-posix.c:65: error: 'environ' undeclared (first use in this
> > > function)
> > > qga/commands-posix.c:65: error: (Each undeclared identifier is reported
> > > only once
> > > qga/commands-posix.c:65: error: for each function it appears in.)
> > >
> > > On F16 environ is declared in <unistd.h>, but that obviously doesn't
> > > happen on all systems.
> > >
> > > Tested on OpenBSD 4.9.
>
> Just tested on 5.1 too.
>
> > > PS: I get zillions of -Wno-redundant-decls errors on OpenBSD 4.8 and still
> > > get other warnnigs if I drop that flag.
>
> All the -Wno-redundant-decls warnings are still there on 5.1, if I remove that
> flag I still get the following ones. Michael, do you want me to fix the
> qemu-ga
> one for 1.1?
I'll take a patch, but unless it constitutes a build fix or an actual
overrun I don't think it's worth targetting for 1.1
The sprintf() has been there for a while now so I think it's okay to fix
later since openbsd does seem to have enough coverage to catch qemu-ga
breakages and it hasn't been mentioned yet.
The usage will also be safe for any architecture where pid_t is
defined to be to be 2^64 or less, so we should be good there as well.
>
> LINK qemu-ga
> /usr/local/lib/libglib-2.0.so.2992.0: warning: vsprintf() is often misused,
> please use vsnprintf()
> /usr/local/lib/libglib-2.0.so.2992.0: warning: stpcpy() is dangerous GNU
> crap; don't use it
> /usr/local/lib/libglib-2.0.so.2992.0: warning: strcpy() is almost always
> misused, please use strlcpy()
> qemu-ga.o(.text+0x358): In function `ga_open_pidfile':
> /home/lcapitulino/qmp-unstable/qemu-ga.c:258: warning: sprintf() is often
> misused, please use snprintf()
>