[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCHv2 1/3] ui/spice-display.c: add missing initializ
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCHv2 1/3] ui/spice-display.c: add missing initialization for valgrind |
Date: |
Thu, 24 May 2012 08:51:40 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.4) Gecko/20120422 Thunderbird/10.0.4 |
On 05/24/12 08:43, Alon Levy wrote:
> On Wed, May 23, 2012 at 08:59:22PM +0200, Gerd Hoffmann wrote:
>> On 05/22/12 17:29, Alon Levy wrote:
>>> We can't initialize QXLDevSurfaceCreate field by field because it has a
>>> pa hole, and so 4 bytes remain uninitialized when building on x86-64, so
>>> just memset.
>>
>> So you get valgrind warnings for the hole? why? nobody should ever
>> access the hole, so the missing initialization should not hurt in theory ...
>
> Because we allocate this struct on the stack and then copy it over an fd
> to spice, through the dispatcher pipe.
Ah, yea, copying will make valgrind complain of course ...
I'll go queue it up.
cheers,
Gerd
- [Qemu-devel] [PATCHv2 1/3] ui/spice-display.c: add missing initialization for valgrind, Alon Levy, 2012/05/22
- [Qemu-devel] [PATCHv2 2/3] hw/qxl: s/qxl_guest_bug/qxl_set_guest_bug/, Alon Levy, 2012/05/22
- [Qemu-devel] [PATCHv2 3/3] hmp/qxl: info spice: add qxl info, Alon Levy, 2012/05/22
- Re: [Qemu-devel] [PATCHv2 1/3] ui/spice-display.c: add missing initialization for valgrind, Gerd Hoffmann, 2012/05/23
- Re: [Qemu-devel] [PATCHv2 1/3] ui/spice-display.c: add missing initialization for valgrind, Alon Levy, 2012/05/24
- Re: [Qemu-devel] [PATCHv2 1/3] ui/spice-display.c: add missing initialization for valgrind,
Gerd Hoffmann <=
- Re: [Qemu-devel] [PATCHv2 1/3] ui/spice-display.c: add missing initialization for valgrind, Gerd Hoffmann, 2012/05/24
- [Qemu-devel] [PATCH 1/4] ui/spice-display.c: add missing initialization for valgrind, Alon Levy, 2012/05/24
- [Qemu-devel] [PATCH 2/4] hw/qxl: s/qxl_guest_bug/qxl_set_guest_bug/, Alon Levy, 2012/05/24
- [Qemu-devel] [PATCH 4/4] qxl: stop dirty loging when not in vga mode, Alon Levy, 2012/05/24
- [Qemu-devel] [PATCH 3/4] hmp/qxl: info spice: add qxl info, Alon Levy, 2012/05/24
- Re: [Qemu-devel] [PATCH 3/4] hmp/qxl: info spice: add qxl info, Gerd Hoffmann, 2012/05/24
- Re: [Qemu-devel] [PATCH 3/4] hmp/qxl: info spice: add qxl info, Alon Levy, 2012/05/24
- [Qemu-devel] [PATCH 1/2] qxl: stop dirty loging when not in vga mode, Alon Levy, 2012/05/24
- [Qemu-devel] [PATCH 2/2] hw/qxl: ignore guest from guestbug until reset, Alon Levy, 2012/05/24
- Re: [Qemu-devel] [PATCH 1/4] ui/spice-display.c: add missing initialization for valgrind, Alon Levy, 2012/05/24