qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] exec: fix breakpoint_invalidate() breakage


From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH] exec: fix breakpoint_invalidate() breakage
Date: Thu, 24 May 2012 13:36:06 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1

On 05/24/2012 01:12 PM, Stefan Weil wrote:
Am 24.05.2012 15:35, schrieb Andreas Färber:
Am 24.05.2012 04:12, schrieb TeLeMan:
I won't use
my Chinese name because I think it's my privacy.

That exactly is touching the core point: Signed-off-by is about
transparency and taking responsibility for your actions, not hiding in
anonymity. It's a certification of whom the code came from and who would
be to blame if anything was wrong with that (think non-GPL-compatible
code taken from somewhere else).

Why should you be granted more privacy than us just because your name is
Chinese? There's quite a few Chinese IBM guys around that don't seem to
have any problem with this, and git would even handle UTF-8 characters
quite well if desired[*].

Andreas


[*] For example,

commit e965fc380703110e967febf8d5b2ecd7db53b5d2
Author: 陳韋任<address@hidden>
Date: Mon Feb 6 14:02:55 2012 +0800

cpu-exec.c: Correct comment about this file and indentation cleanup

Each target uses the #define macro (in target-xxx/cpu.h) to rename
cpu_exec (cpu-exec.c) to cpu_xxx_exec, then defines its own cpu_loop
which calls cpu_xxx_exec. So basically, cpu-exec.c is not only the i386
emulator main execution loop. This patch corrects the comment of this
file and does indentation cleanup.

Signed-off-by: Chen Wei-Ren (陳韋任)<address@hidden>
Signed-off-by: Stefan Hajnoczi<address@hidden>

This discussion looks strange for me.

I'm not going to commit patches with a Signed-off-by if I know the name is an 
alias.

DCO requires the use of a real name. DCO is an important part of ensuring the pedigree of a code base just like copyright licensing.

Regards,

Anthony Liguori



reply via email to

[Prev in Thread] Current Thread [Next in Thread]