Re: [Qemu-devel] [PATCH 7/9] unicore32-softmmu: add puv3 soc support

[Andreas Färber]

Am 25.05.2012 13:29, schrieb Guan Xuetao:
> This patch only add minimal necessary system-control modules simulation
> for successfully kernel booting and busybox running.
> 
> Signed-off-by: Guan Xuetao <address@hidden>
> ---
>  hw/pkunity/puv3.c      |  130 +++++++++++++++++++++++++++++++++++++++++
>  hw/pkunity/puv3.h      |   49 ++++++++++++++++
>  hw/pkunity/puv3_dma.c  |  109 ++++++++++++++++++++++++++++++++++
>  hw/pkunity/puv3_gpio.c |  141 ++++++++++++++++++++++++++++++++++++++++++++
>  hw/pkunity/puv3_intc.c |  135 ++++++++++++++++++++++++++++++++++++++++++
>  hw/pkunity/puv3_ost.c  |  151 
> ++++++++++++++++++++++++++++++++++++++++++++++++
>  hw/pkunity/puv3_pm.c   |  148 +++++++++++++++++++++++++++++++++++++++++++++++
>  7 files changed, 863 insertions(+), 0 deletions(-)
>  create mode 100644 hw/pkunity/puv3.c
>  create mode 100644 hw/pkunity/puv3.h
>  create mode 100644 hw/pkunity/puv3_dma.c
>  create mode 100644 hw/pkunity/puv3_gpio.c
>  create mode 100644 hw/pkunity/puv3_intc.c
>  create mode 100644 hw/pkunity/puv3_ost.c
>  create mode 100644 hw/pkunity/puv3_pm.c

Added a subdirectory without adapting configure and possibly Makefiles
will break out-of-tree builds. Can't you just name the files
puv3_something.[ch] as done for other SoCs?

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg