Re: [Qemu-devel] [PATCH] Support virtio-scsi-pci adapter hot-plug

[Stefan Hajnoczi]

On Thu, May 24, 2012 at 7:31 AM, Kelvin Wang <address@hidden> wrote:
> On Wed, May 23, 2012 at 05:45:33PM +0300, Michael S. Tsirkin wrote:
>> On Wed, May 23, 2012 at 04:30:06PM +0200, Paolo Bonzini wrote:
>> > Il 23/05/2012 16:12, Michael S. Tsirkin ha scritto:
>> > >> > 2, Run qemu with the option -monitor.
>> > >> >
>> > >> > 3, In the guest, insert necessary modules:
>> > >> > for m in acpiphp pci_hotplug; do sudo modprobe ${m}; done
>> > >> >
>> > >> > 4, In the qemu monitor,hot add a virtio-scsi-pci adapter:
>> > >> > (qemu)pci_add auto storage if=virtio-scsi-pci
>> > >> >
>> > >> > 5, Check whether the controller was added:
>> > >> > Guest: lspci
>> > >> > Qemu: (qemu)info qtree
>> > >> >
>> > >> > Signed-off-by: Kelvin Wang <address@hidden>
>> > >> > Signed-off-by: Sheng Liu <address@hidden>
>> > > NAK
>> > >
>> > > Do not use pci_add. It is a compatibility command.
>> > > Use the new style device_add.
>> > > Same for if=.
>> > >
>> > > I think you won't need any changes then?
>> > >
>> >
>> > You don't.  You need to rescan the bus manually in the guest, that's all.
>> >
>> > Paolo
>>
>> If the point is to avoid need for manual bus rescans that's
>> good. But please do not touch the legacy commands.
> So, may I sent another patch to "avoid need for manual bus rescans"?

This is LUN hotplug support.

Stefan