[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qemu_find_file: check name as a straight path e
From: |
Edgar E. Iglesias |
Subject: |
Re: [Qemu-devel] [PATCH] qemu_find_file: check name as a straight path even if it has no '/' |
Date: |
Fri, 25 May 2012 14:23:28 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Fri, May 25, 2012 at 02:21:55PM +0200, Andreas Färber wrote:
> Am 25.05.2012 14:07, schrieb Peter Maydell:
> > Make qemu_find_file() check for the passed in name as a straight
> > pathname even if it doesn't have any path separator character in it.
> > This means that "-bios foo", "-dtb foo" etc will find a file 'foo'
> > in the current directory.
> > This removes an inconsistency with -kernel and -initrd, which both
> > accept plain filenames as meaning files in the current directory.
> > It's also less confusing for the user than an undocumented restriction
> > that "this option accepts a filename, except for the special case
> > where the filename you pass happens not to have a '/' in it, in
> > which case we'll ignore it."
> >
> > Signed-off-by: Peter Maydell <address@hidden>
>
> Speaking of inconsistencies, I also noticed that the ppc virtex-ml507
> machine relies on the .dtb being in the current directory with
> apparently no way to override. Any chance this can be fixed, Edgar?
> Maybe it can be unified with the dtb handling on ARM or share the same
> QemuOpts?
Yes, absolutely!
Best regards,
Edgar